Shutting down executors that are passed in by the user is not a
good default. Previously this was useful because ipykernels would
not shut down correctly because of some weird interaction with open
'concurrent.futures.Executor's, but this has since been fixed.
... | ... |
@@ -71,7 +71,7 @@ class BaseRunner: |
71 | 71 |
of cores available in 'executor'. |
72 | 72 |
log : bool, default: False |
73 | 73 |
If True, record the method calls made to the learner by this runner |
74 |
- shutdown_executor : Bool, default: True |
|
74 |
+ shutdown_executor : Bool, default: False |
|
75 | 75 |
If True, shutdown the executor when the runner has completed. If |
76 | 76 |
'executor' is not provided then the executor created internally |
77 | 77 |
by the runner is shut down, regardless of this parameter. |
... | ... |
@@ -87,7 +87,7 @@ class BaseRunner: |
87 | 87 |
|
88 | 88 |
def __init__(self, learner, goal, *, |
89 | 89 |
executor=None, ntasks=None, log=False, |
90 |
- shutdown_executor=True): |
|
90 |
+ shutdown_executor=False): |
|
91 | 91 |
|
92 | 92 |
self.executor = _ensure_executor(executor) |
93 | 93 |
self.goal = goal |